Closed maheshsattala closed 2 months ago
This update introduces significant enhancements to the scheduling action functionality in the application. The ScheduleActionRequest
class now expects a revised parameter structure, enhancing compatibility and functionality. Corresponding test cases have been expanded to validate the new expectations, ensuring robust coverage for both the creation and retrieval of scheduled actions. Overall, these changes aim to improve the scheduling process while maintaining the reliability of the API.
Files | Change Summary |
---|---|
kairon/api/models.py |
Modified ScheduleActionRequest to change params_list from Optional[List[CustomActionParameter]] to Optional[List[HttpActionParameters]] . |
tests/integration_test/services_test.py |
Added new tests for validating invalid parameters, listing actions, and updated existing tests to include a required key in params_list . |
tests/unit_test/data_processor/data_processor_test.py |
Enhanced params_list in test_add_schedule_action and added test_update_schedule_action_params_list to validate new structure. |
sequenceDiagram
participant Client
participant API
participant Scheduler
Client->>API: Request to add schedule action
API->>Scheduler: Validate params_list
Scheduler-->>API: Return success or error
API-->>Client: Return response
sequenceDiagram
participant Client
participant API
participant Scheduler
Client->>API: Request to list schedule actions
API->>Scheduler: Retrieve scheduled actions
Scheduler-->>API: Return actions list
API-->>Client: Send actions to client
🐰 In fields of code, I hop with glee,
New params dance, as bright as can be.
Actions now scheduled with care and delight,
Our tests stand strong, all ready to fight!
With changes embraced, we bound ever high,
A rabbit's cheer for improvements, oh my! 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
made changes related to params list in schedule action and added test cases related to that.
Summary by CodeRabbit