search

digiteinfotech / kairon

Conversational AI Platform to build effective Proactive Digital Assistants using Visual LLM Chaining
https://kairon.nimblework.com/bots
Apache License 2.0
248 stars 78 forks source link

Executor Logs #1499

Closed maheshsattala closed 2 months ago

maheshsattala commented 2 months ago

Added code for executor logs and fixed respective test cases and added test cases for the same.

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

This pull request introduces significant enhancements across multiple files in the Kairon project. Key modifications include the addition of a task_type parameter in various method signatures, enabling better categorization of tasks. The CloudUtility class has been updated to improve logging and error handling during lambda function invocations. Additionally, a new TASK_TYPE enumeration has been introduced to provide structured task categorization. The changes also extend to test cases, ensuring that task execution details are logged and verified correctly.

Changes

Files Change Summary
kairon/async_callback/processor.py Added task_type parameter to run_pyscript function, utilizing TASK_TYPE.CALLBACK.value in CloudUtility.trigger_lambda.
kairon/events/executors/base.py Modified execute_task to accept **kwargs, added log_task method for detailed logging of task execution.
kairon/events/executors/dramatiq.py Updated execute_task method to include **kwargs, enhanced logging and error handling during task execution.
kairon/events/executors/lamda.py Modified execute_task to accept **kwargs, extracted task_type from kwargs for use in CloudUtility.trigger_lambda.
kairon/events/executors/standalone.py Updated execute_task method to accept **kwargs, improved error handling and logging based on execution outcome.
kairon/events/scheduler/base.py Modified add_job and update_job methods to include task_type parameter.
kairon/events/scheduler/kscheduler.py Updated add_job and update_job methods to include task_type, allowing dynamic job context adjustment.
kairon/events/utility.py Added task_type parameter to add_job and update_job methods, standardizing task type for scheduled events.
kairon/shared/actions/utils.py Added task_type argument to perform_web_search and run_pyscript functions for lambda invocations.
kairon/shared/cloud/utils.py Enhanced trigger_lambda method with task_type and from_executor parameters, added log_task method for logging execution details.
kairon/shared/data/constant.py Introduced TASK_TYPE enumeration with constants for ACTION, EVENT, and CALLBACK.
kairon/shared/events/data_objects.py Added ExecutorLogs class for logging execution events with various fields.
tests/unit_test/callback_test.py Modified test_run_pyscript to include task_type in the mock call for trigger_lambda.
tests/unit_test/cloud_utils_test.py Added new tests for CloudUtility class, focusing on lambda invocation scenarios and logging.
tests/unit_test/events/executors_test.py Updated tests for DramatiqExecutor and StandaloneExecutor to include task_type in execute_task calls, added logging assertions.
tests/unit_test/events/scheduler_test.py Modified tests for KScheduler to replace hardcoded event types with TASK_TYPE.EVENT.value, enhancing maintainability.

Possibly related PRs

🐰 In the meadow where bunnies hop,
New tasks are added, we can't stop!
With types defined, our work's a breeze,
Logging details brings us ease.
So let us cheer for changes bright,
In Kairon's code, all feels just right! 🌼✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.