Closed GMayank0310 closed 4 days ago
The pull request introduces significant changes to the remove_bot_access
function in the kairon/shared/account/processor.py
file, transitioning from retrieving a collection of BotAccess
objects to expecting a single object. Additionally, the get_collection_data
function in kairon/api/app/routers/bot/data.py
is enhanced to accept multiple filter criteria, and a new function get_collection_data_with_id
is added. Several test functions in tests/integration_test/services_test.py
are removed and replaced with new tests that maintain the same logical structure but utilize different user accounts and bot identifiers.
File Path | Change Summary |
---|---|
kairon/shared/account/processor.py | Updated remove_bot_access to retrieve a single BotAccess object instead of a collection. |
kairon/api/app/routers/bot/data.py | Modified get_collection_data to accept multiple keys and values; added get_collection_data_with_id . |
kairon/shared/cognition/processor.py | Added get_collection_data_with_id method; modified get_collection_data to handle multiple filters. |
tests/integration_test/services_test.py | Removed old test functions for bot membership and added new tests with different user accounts and bot IDs, preserving original logic. |
tests/unit_test/data_processor/data_processor_test.py | Added tests for mismatched filter lengths and collection data retrieval by ID. |
get_collection_data
function that are directly related to the changes in the main PR regarding how collection data is retrieved.get_collection_data
function to accept multiple filters, which aligns with the changes in the main PR that also involve modifications to the data retrieval logic in the CognitionProcessor
class.🐇 In the meadow, changes bloom,
A bot's access finds new room.
With tests anew, we hop and play,
Ensuring all works day by day.
A single path, a clearer way,
Let's cheer for code, hip-hip-hooray! 🥕
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
fix audit log issues when user leaves bot, deletes a member and when a bot is deleted
Summary by CodeRabbit
New Features
Bug Fixes
Tests