Add two optionals tags - Githubissues

digitick / php-sepa-xml

* THIS PROJECT IS NO LONGER MAINTAINED* SEPA file generator in PHP

107 stars 63 forks source link

Add two optionals tags #41

Open elrico77 opened 10 years ago

elrico77 commented 10 years ago

1) transaction id, this is a complement to EndToEndId 2) FinInstnId/Othr/Id tag with NOTPROVIDED only when BIC is set to NOTPROVIDED, this way, the logic is not in the XML generator.

ch3ric commented 10 years ago

Please fix the coding style:

Space before/after closing parenthesis of function call prohibited
Expected "} else {\n"; found "}\n else {\n"

And add PHPUnit test case to make sure everything is working correctly with the new fields

Also, I think the BIC is mandatory in SEPA exports... Are you sure banks will accept files with BIC = 'NOTPROVIDED'?

elrico77 commented 10 years ago

Hello,

the BIC is mandatory only in cross border transactions and until 31 January 2016 (exemple: http://www.betaalvereniging.nl/wp-uploads/2013/01/XML-Message-for-SDD-Version-7.0-February-2013.pdf). The tag "DbtrAgt" is a mandatory one. This version is used for SDD with french bank "Société Générale".

For the coding style and PHPUnit test, i'll fix that ASAP (monday i think).