Added <UltmtCdtr> to the generated XML

digitick / php-sepa-xml

* THIS PROJECT IS NO LONGER MAINTAINED* SEPA file generator in PHP

107 stars 63 forks source link

Added <UltmtCdtr> to the generated XML #43

Closed cristianciofu closed 10 years ago

cristianciofu commented 10 years ago

The field is not mandatory, but it may be asked for the validation of the XML file (for example I needed it)

ch3ric commented 10 years ago

@cristianciofu

Are you sure this field is supported by both pain.008.002.02 and pain.008.001.02?
Please add a test in CustomerDirectDebitValidationPain00800102Test.php to make sure it works with this new field.

cristianciofu commented 10 years ago

Added support for <AmdmntInd> and <AmdmntIndDtls>

@ch3ric - I'll add the tests for UltmtCdtr and also for the 2 new fields I just added.

Thanks

ch3ric commented 10 years ago

Thanks @cristianciofu. The code seems good to me, but you definitely need to add tests to make sure the XML files generated are still valid for both formats with the 3 fields you added.

cristianciofu commented 10 years ago

@ch3ric - updated the code :

1) Added the tests for <AmdmntInd> (the new optional tag I've just added)

2) As for the <UltmtCdtr> I've run the tests and they pass... So I think it's ok (this is added each time, so if the XSD check pass for me that means that there are no issues). Please correct me if I'm wrong.

Thanks

ch3ric commented 10 years ago

OK for the tests.
It would be better to have all the code about AmdmntInfDtls in another branch and PR if you want this one to be merged first.

cristianciofu commented 10 years ago

@ch3ric yes, you are right. I will split the modifications in 2 separate branches (one for each new tag added). If I have the time I will do this next week.

For now I will cancel this pull request...

For UltmtCdtr I think I've made an error adding the following informations : $paymentInformation->getOriginName() and $paymentInformation->getOriginAccountIBAN().

These informations can be different, so it's better to have the possibility to also define them... And also add it to the XML tree only if the user asks for it.