Extending Item class to add more properties

digitickets / omnipay-barclays-epdq

Barclays ePDQ Essential payment gateway integration into the Omnipay library.

MIT License

10 stars 17 forks source link

Extending Item class to add more properties #10

Closed GhaziTriki closed 9 years ago

GhaziTriki commented 9 years ago

This API offers more properties that can describe an Item :

ITEMATTRIBUTESXX ITEMCATEGORYXX ITEMCOMMENTSXX ITEMDESCXX ITEMDISCOUNTXX ITEMFDMPRODUCTCATEGXX ITEMIDXX ITEMNAMEXX ITEMPRICEXX ITEMQUANTXX ITEMQUANTORIGXX ITEMUNITOFMEASUREXX ITEMVATXX ITEMVATCODEXX ITEMWEIGHTXX

I will create a pull request to add the those parameters.

How Item class should be extended? As we have now a specific need and we need to stay Omnipay compliant. Any suggestion?

coatesap commented 9 years ago

@GhaziTriki - It might be worth having a look at some of the other Omnipay drivers, as I'm sure there are probably quite a few that implement passing of item/cart information through to the gateway...

GhaziTriki commented 9 years ago

I have taken a look at them all I haven't found any custom implementation of Item class. I will take a deeper look.

GhaziTriki commented 9 years ago

A pull request almost ready. I need a clarification about 3 parameters from Barclays and I will be able to push and be ready to release a new version.