Split return url to three different variables

digitickets / omnipay-barclays-epdq

Barclays ePDQ Essential payment gateway integration into the Omnipay library.

MIT License

10 stars 17 forks source link

Split return url to three different variables #17

Closed GhaziTriki closed 9 years ago

GhaziTriki commented 9 years ago

After some testing I have discovered that the return URL is correctly working in contrary of what it is explained in the README. I will provide a pull request once all is tightly tested.

GhaziTriki commented 9 years ago

Actually setReturnUrl in EssentialPurchaseRequest class sets three different variables with the same value and the method testSettersAndGetters is asserting that those three values are the same.

I think that splitting them is wise to give more flexibility to developer, I have also made some tests with those variables and they are working so the second point in "tips" does no more make a sense. What do you think?