search

digitickets / omnipay-barclays-epdq

Barclays ePDQ Essential payment gateway integration into the Omnipay library.
MIT License
10 stars 17 forks source link

Split the 3 url parameters setter #18

Closed GhaziTriki closed 9 years ago

GhaziTriki commented 9 years ago

ref #17 : the three response back url can now be different.

coatesap commented 9 years ago

Hi Ghazi, I haven't actually tested this, but does it actually remove the ability to just set a single return url using the generic returnUrl parameter? If so, this would break many existing integrations (including mine!), and deviate away from the OmniPay principle of being able to swap between payment gateway drivers easily. One solution might be to let the setReturnUrl method just call the other methods, setting the individual urls to whatever was passed in the generic returnUrl param...

Cheers, Andy

GhaziTriki commented 9 years ago

I thought about it and I was sure that it has bad implications. I like the backward compatibility fallback you have proposed and I will implement it.

samvaughton commented 9 years ago

Hi @GhaziTriki I have given you access to the repo so you can merge these yourself like Andy suggested. Just make sure to keep BC for @coatesap and write tests =)

GhaziTriki commented 9 years ago

Thank you very much. I am really grateful you have given me access to the repository. I will add unit tests for this.

samvaughton commented 9 years ago

You're welcome :+1: