search

digitickets / omnipay-barclays-epdq

Barclays ePDQ Essential payment gateway integration into the Omnipay library.
MIT License
10 stars 17 forks source link

Incorrect Namespace #22

Open greydnls opened 8 years ago

greydnls commented 8 years ago

Hi, I very much value your work on this gateway, however it shouldn't e using the Omnipay namespace. Can you please update it to use your own namespace?

samvaughton commented 8 years ago

I don't understand - many third party packages use the Omnipay namespace to start with.

http://omnipay.thephpleague.com/gateways/third-party/

To name a few:

Changing the namespace will also cause breaking changes, and is unnecessary.

coatesap commented 8 years ago

I actually think it's probably a good idea, as it means if you want to try out different/competing drivers side by side, there isn't a namespace collision. Also hypothetically if two people create two different drivers that fulfil different integration methods for the same gateway, you might not be able to use them both if they shared the same namespace...

samvaughton commented 8 years ago

Yeah Andy the points are valid - any pull requests I'll accept to change the namespaces as I don't really maintain it anymore.

The version will have to be increase to indicate breaking changes though.

Cheers, Sam On 13 Oct 2015 7:19 p.m., "Andrew Coates" notifications@github.com wrote:

I actually think it's probably a good idea, as it means if you want to try out different/competing drivers side by side, there isn't a namespace collision. Also hypothetically if two people create two different drivers that fulfil different integration methods for the same gateway, you might not be able to use them both if they shared the same namespace...

— Reply to this email directly or view it on GitHub https://github.com/samvaughton/omnipay-barclays-epdq/issues/22#issuecomment-147801254 .