search

digitickets / omnipay-realex

Realex payment gateway driver for the Omnipay library
7 stars 24 forks source link

Added ability to change endpoint urls #16

Open 3dgroup opened 8 years ago

coatesap commented 8 years ago

Hi @3dgroup - from a quick skim through this change looks like it could potentially break existing installations. Is the default Realex endpoint provided somewhere?

3dgroup commented 8 years ago

No your right, let me change it.

3dgroup commented 8 years ago

This should have resolved the issue you mentioned by adding the default payandshop urls into the default config array.

James-Byrne commented 8 years ago

Hey, I just made a pull request, one part of which allows you to change one of the endpoints, is there any issues with this request as it stands? If not I will gladly take that section out of my pull request.

coatesap commented 8 years ago

@James-Byrne - no, I think your implementation actually looks cleaner, so I'll probably merge yours instead. I'm guessing that your endpoint changes are to allow you to use it with white-labelled versions of Realex?

3dgroup commented 8 years ago

@coatesap To me there is more than one end point URL and @James-Byrne commit only seems to cover the Auth URL not the data vault end point url.

coatesap commented 8 years ago

@3dgroup - yes, good point. @James-Byrne - have you any thoughts how this could be addressed?

James-Byrne commented 8 years ago

I think the pr by @3dgroup is far more comprehensive than the one I have made and covers my current use case as well as use cases I may have in the future. If you can resolve the outstanding issues you have yourself (styling, backwards compatibility etc) then I think this is the better option.

coatesap commented 8 years ago

Thanks @James-Byrne, now that I've had chance to look properly at the commits, I'd agree. On that basis - @3dgroup - are you able to address the two comments I've added to the PR, and sort the indentation (tab is 4 spaces in Omnipay land, I believe), and I'll get this merged.

3dgroup commented 8 years ago

I think the tab issue is from my college istvan when he resolved an XML issue regarding special characters. He will be updating this today.

slogsdon commented 6 years ago

What's the status of this PR? My team is working on Realex Hosted Payment Page / Redirect support as well, and it looks like some of the functionality will overlap what's being added here.

3dgroup commented 6 years ago

My Fork is working fine, https://github.com/3dgroup/omnipay-realex