digitoimistodude / air-cookie

12 stars 2 forks source link

Upgrade cookieconsent.js to version 3 #3

Open ronilaukkarinen opened 4 months ago

ronilaukkarinen commented 4 months ago

3.0.0 released, but contains lots of breaking changes and should be implemented and tested thoroughly.

rahkapetteri commented 4 months ago

Hi and thanks for the awesome plugin! 💪

I started fork-project to update CookieConsent to version 3.0.0. Some initial tests are working (loading scripts after cookies have been accepted without extra js), but I need to do more testing with different kinds of cases. Documentation update is also on my to do -list.

2 is fixed also.

I´m planning to test all cases from original readme and do some minor stuff. After comprehensive testing i could do PR.

Just for info 💡

ronilaukkarinen commented 4 months ago

@rahkapetteri That is so awesome! Saves us a lot of time as we are overly busy right now and been doing fine with v2.9.1. A PR would be much appreciated, we can then run our own tests and create release with proper contribution credits. 🫶🏻