search

digitoimistodude / air-light

💨 WordPress starter theme - designed to be minimal, ultra-lightweight (< 20 kB) and easy for all kinds of WordPress projects. 7+years/1000+hours of development and still updating daily! We prefer the original WordPress way of doing things so no strange templating languages or frameworks here.
https://airwptheme.com
MIT License
929 stars 139 forks source link

Improve a11y of mobile nav js #175

Closed michaelbourne closed 1 year ago

michaelbourne commented 1 year ago

Fixes some irregularities with keyboard navigation + focus trap. You can replicate the current issues on your dev site by shrinking the window to trigger the mobile nav, but use your keyboard to navigate the site.

This also allows for hidden element and disabled element edge cases.

height[bot] commented 1 year ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

ronilaukkarinen commented 1 year ago

Heyy @michaelbourne, thanks a lot for the effort! You are a godsend. I was actually struggling with the focus trap earlier and didn't have time to polish these things

I have now tested the changes, first try showed up some strange leftover _5forests_theme_strings in the code but they seemed to be gone after rebuild. Looks fine to me!

Will later add these changes to a release. Thanks again. ❤️

michaelbourne commented 1 year ago

Oh shoot, I forgot to replace those! I have this theme heavily modified for our own starter but keep it in sync with your master as close as I can. I'll double check the strings next time I PR :)