Improvements and fixes to top scroll button (#190)

digitoimistodude / air-light

💨 WordPress starter theme - designed to be minimal, ultra-lightweight (< 20 kB) and easy for all kinds of WordPress projects. 7+years/1000+hours of development and still updating daily! We prefer the original WordPress way of doing things so no strange templating languages or frameworks here.

https://airwptheme.com

MIT License

945 stars 142 forks source link

Improvements and fixes to top scroll button (#190) #191

Closed raikasdev closed 1 year ago

raikasdev commented 1 year ago

This pull request improves the scroll to top button.

Taking into account prefers-reduced-motion (scrolling instantly if reduced)
Visually focusing to the first element if on keyboard (actually showing the "Skip to content"-button)
Fixes the jankiness of scrolling on Firefox. Closes #190
- This was caused by .focus() scrolling the user to the top for a moment before moveTo kicked in. It scrolled 5 pixels down instead of absolute top on Chromium, which broke moveTo.

height[bot] commented 1 year ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.