digitoimistodude / air-light

💨 WordPress starter theme - designed to be minimal, ultra-lightweight (< 20 kB) and easy for all kinds of WordPress projects. 7+years/1000+hours of development and still updating daily! We prefer the original WordPress way of doing things so no strange templating languages or frameworks here.
https://airwptheme.com
MIT License
929 stars 139 forks source link

For PHP8+: Remove deprecated stylelint rule and rename PHPCS rule #195

Closed raikasdev closed 5 months ago

raikasdev commented 10 months ago
height[bot] commented 10 months ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

ronilaukkarinen commented 9 months ago

@raikasdev PHPCS fails to error ERROR: Referenced sniff "PHPCSUtils" does not exist. Can't get it to work on master or develop either, had to get -b 2.2.0. Strange. But unit test should go through, can you try and test it again? 🤔

raikasdev commented 9 months ago

Ah, in 3.0.0 of the WordPress PHPCS rules PHPCSUtils was added as a dependency (might have been built-in before) and must be installed. I'll add them to the workflow, but they also need to be added to documentation (devpackages README also?)

3.0.0 is for PHP 8 support, so this PR isn't perhaps that critical right now, but as PHP 7.4 has reached end-of-life already and the WP team is trying to get PHP 8 full support released, probably good to have this ready.

"Dependencies on the following packages: PHPCSUtils, PHPCSExtra and the Composer PHPCS plugin."

ronilaukkarinen commented 5 months ago

Added separately without this PR.