digitsensitive / astar-typescript

A* search algorithm in TypeScript
MIT License
87 stars 18 forks source link

option to suppress console log? #4

Closed krazyjakee closed 4 years ago

krazyjakee commented 4 years ago

https://github.com/digitsensitive/astar-typescript/blob/5062cbbf7d6b3ff054d99cd5acc8f28c5604c315/lib/finders/astar-finder.ts#L78

https://github.com/digitsensitive/astar-typescript/blob/5062cbbf7d6b3ff054d99cd5acc8f28c5604c315/lib/finders/astar-finder.ts#L177

These are nasty in production. Whether it should throw an error or return an empty array, I'm not sure. I actually prefer empty array.

digitsensitive commented 4 years ago

Hello @krazyjakee! Thank you for your input. I might use an environment variable for this in the future. But for now I will simply delete the console.log's.

digitsensitive commented 4 years ago

The version 1.1.8 is now online

krazyjakee commented 4 years ago

thanks very much :)