diglabby / mapa

Repository for Mapa project
GNU Affero General Public License v3.0
15 stars 21 forks source link

Add/Edit Event: Image url and on-click link are not saved #162

Open antos-k opened 5 years ago

antos-k commented 5 years ago
  1. Open map
  2. Press 'Add new entry' (or edit existing event)
  3. Select 'Event' category as Event
  4. Fill all fields correctly
  5. Fill Image field with correct url of any image, for example, https://sun9-55.userapi.com/c857736/v857736486/4458a/xmgrrpcq_Ek.jpg
  6. Fill other fields correctly
  7. Press Save

Results: Image and link are not saved (we can check it if open this event for editing). At this time for Initiatives all saved correctly.

Expected: Image link and url are saved successfully

Selection_019

PolinaSam commented 4 years ago

@antos-k, I tried to add an event and incountered the following error mistake

rizomaa commented 4 years ago

@Anthony-Hoopkins does it still have importance now?

rizomaa commented 4 years ago

Add tests

  1. Different browsers (browser stack)
  2. Tablet or mobile.
  3. Social networks (inst, vk, fb)
ArtyomKr commented 4 years ago

I tried to test it, and it's a bigger issue: I can't add any events at all. It seem that there's some issues with CORS headers at https://api.ofdb.io/v0/events. Maybe https://mapa.falanster.by/ doesn't have access to this url. Annotation1 Annotation2 Annotation 2020-06-05 173008

ArtyomKr commented 4 years ago

@rizomaa I need some input from someone who knows about project back-end

rizomaa commented 4 years ago

@ArtyomKr hello,

Thanks for the request. I send the issue to the german developer, when they share link you will be invited.

Do you try to add event online or on you local frontend installation?

ArtyomKr commented 4 years ago

@rizomaa I tried both and the result is the same. image

wellemut commented 4 years ago

It is really strange. In kvm it works perfectly: https://kartevonmorgen.org/#/?entry=62b2d765dd5b4e1b9091b3d59a3a2507&zoom=15.00 Same entry in map does not work: https://mapa.falanster.by/#/?entry=62b2d765dd5b4e1b9091b3d59a3a2507&zoom=15.00

@rizomaa Is is definitly a frontend problem. I suggest you compare the frontendcode of kvm

rizomaa commented 4 years ago

@wellemut thanks.

Could you provide your URL.js ? It helps us to understand configuration

navid-kalaei commented 4 years ago

I tried to reproduce the error but failed and the project is working flawlessly. Could you please try to check if the issue still exists? If so could I kindly give me a clue how should I reproduce that? Maybe a short video could help. Thanks in advance.

ArtyomKr commented 4 years ago

@navid-kalaei Thanks for your input. It still exists.

  1. Go to https://mapa.falanster.by/#map .
  2. Click "add new entry".
  3. Select event ("падзея").
  4. Fill the necessary fields.
  5. Click add. image It happens every time for me
navid-kalaei commented 4 years ago

@ArtyomKr you are very welcome :+1:

The server that serves your front-end should be allowed by our backend. I'll check that with @flosse and @uklotzde to find the solution.

More details:

rizomaa commented 4 years ago

@ArtyomKr please look here, maybe it helps you also https://github.com/diglabby/mapa/pull/368

rizomaa commented 4 years ago

from telegram " Navid Kalaei, [13.06.20 05:56] Rizoma we had an issue about six months ago or so that the redux debugger extension had made karte von morgen halt. please update that script asap. clients with redux extention enabled are not able to open mapa. the fixation is currently deployed on our repository.

Navid Kalaei, [13.06.20 06:09] Rizoma I checked that. Strangely I could not reproduce the error you have shown and everything is working perfectly. could you please retry to see if you still have the error? "

rizomaa commented 4 years ago

@ArtyomKr any progress here?

ArtyomKr commented 4 years ago

@uklotzde Hello, maybe you know something about this problem? I'm talking about https://github.com/diglabby/mapa/issues/162#issuecomment-640048844 .

rizomaa commented 4 years ago

@ArtyomKr If the Adiing initiative works but not event. Did you compare code in both places? Because from developer perspective event and initiative are just different tags here.

ArtyomKr commented 4 years ago

@rizomaa Yes, I compared the code for both and it looks similar. This issue is now my priority so I'll dig deeper into this.

rizomaa commented 4 years ago

@navid-kalaei cuould you share us you config for frontend?

@ArtyomKr ok, any thoughts and progress put here)

ArtyomKr commented 4 years ago

I tried to reproduce original issue, but I didn't encounter any problems. I think it's closed by #397 .

rizomaa commented 4 years ago

@ArtyomKr thanks, if you checked something and consider as a done please move to "Review in progress" column