diglactic / laravel-breadcrumbs

Laravel Breadcrumbs - A simple Laravel-style way to create breadcrumbs.

https://packagist.org/packages/diglactic/laravel-breadcrumbs

MIT License

868 stars 63 forks source link

New template for Bootstrap 5 #16

Closed Kvaksrud closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #16 (bba782f) into main (7a4db95) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #16   +/-   ##
=========================================
  Coverage     90.62%   90.62%           
  Complexity       62       62           
=========================================
  Files             9        9           
  Lines           192      192           
=========================================
  Hits            174      174           
  Misses           18       18

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a4db95...55f6e42. Read the comment docs.

shengslogar commented 3 years ago

Thanks for the PR. I'm hesitant to merge this in, since it's identical to the existing Bootstrap 4 template outside of the wrapping <nav> element. Is there something I'm missing here?

https://github.com/diglactic/laravel-breadcrumbs/blob/7a4db9535cf656340ed1f148c5ff035b436e7731/resources/views/bootstrap4.blade.php#L1-L15

Kvaksrud commented 3 years ago

Renamed to Bootstrap 5 as it is based on it

shengslogar commented 3 years ago

Thanks. I deleted my last comment because I noticed the Bootstrap 4 spec was actually supposed to have the wrapping <nav> but it didn't make it into our bootstrap4 template and I was thinking about consistency. We have wrapping elements in other templates, though, so this makes sense.

I'll merge this in and tag shortly. Thanks! 🚀

Kvaksrud commented 3 years ago

Thanks! :)

shengslogar commented 3 years ago

Tagged v6.1.0