search

digma-ai / digma-intellij-plugin

Digma JetBrains plugin
MIT License
31 stars 7 forks source link

enable instrumented jars #1729

Open shalom938 opened 7 months ago

shalom938 commented 7 months ago

jetbrains recommend using the instrumented jar https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#multi-module-project but there is a bug. https://github.com/digma-ai/digma-intellij-plugin/issues/1017 https://youtrack.jetbrains.com/issue/IDEA-318263#focus=Comments-27-7274096.0-0

one option is to enable instrumented jars only in github build but not in development. the problem would be that the in development we will test different code then in production

its possible to disable instrumentation in the intellij extension for development and enable it in github.

Jakub says he will address that in 2.0 https://jetbrains-platform.slack.com/archives/CPL5291JP/p1706555486673889

shalom938 commented 7 months ago

// todo: jetbrains recommend using the instrumented jar // https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#multi-module-project // but there is a bug. // https://github.com/digma-ai/digma-intellij-plugin/issues/1017 // https://youtrack.jetbrains.com/issue/IDEA-318263#focus=Comments-27-7274096.0-0 // the workaround suggested in youtrack didn't work // but this may work: // if (project.findProperty("IsGithubBuild") == null) { // implementation(project(":ide-common")) // implementation(project(":jvm-common")) // implementation(project(":python")) // implementation(project(":rider")) // } else { // implementation(project(":ide-common", "instrumentedJar")) // implementation(project(":jvm-common", "instrumentedJar")) // implementation(project(":python", "instrumentedJar")) // implementation(project(":rider", "instrumentedJar")) // }