Closed kshmidt-digma closed 1 year ago
@kshmidt-digma @shaykeren @doppleware
See PR: add data about span insights jaeger
questions:
1) can there be no insights for a span?
I mean that getInsights returns empty list. see here: JaegerUIService
2) I filtered Unmapped insights from getInsights, is that ok? see JaegerUIService
3) can there be more then one insight with same type for a span? if not then we don't need this distinct function: distinctByType
4) Sometimes there are two trace buttons that want to show the same span+traceId, for example in method OwnerRepository#findPetTypes. They will show the same editor.
To display insights in Jaeger UI for each span plugin needs to provide additional payload in message.
API changes:
Message names have been replaced to avoid confusion and be more accurate to the their current behaviour:
GET_SPANS_WITH_RESOLVED_LOCATION
->GET_SPANS_DATA
SET_SPANS_WITH_RESOLVED_LOCATION
->SET_SPANS_DATA
SET_SPANS_DATA
message payload should be the following:Example:
Dev noted: We should show all insights related to the span, currently in the backend we are getting only high-importance insights so this filter should be removed.