dignifiedquire / pull-length-prefixed

Streaming length prefixed buffers with pull-streams
MIT License
8 stars 18 forks source link

Travis builds failing with latest npm for older node versions #14

Closed jacobheun closed 6 years ago

jacobheun commented 6 years ago

Now that npm >6 is being installed during the Travis builds, npm commands fail due to npm using let outside of strict mode on older node versions.

0.09s$ npm run lint
/home/travis/.nvm/versions/node/v4.9.1/lib/node_modules/npm/bin/npm-cli.js:79
      let notifier = require('update-notifier')({pkg})
      ^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:140:18)
    at node.js:1043:3

Either npm needs to be locked down, or the travis node versions need to get upgraded. With node v4 having hit end of life this past April it might be best to just update travis to node 6 and 8.

I've got a passing build of the upgrades to travis, it required a rebuild of the lock files to get node stable passing. https://travis-ci.org/jacobheun/pull-length-prefixed/builds/401298678

dignifiedquire commented 6 years ago

drop it like it’s hot On 7. Jul 2018, 22:54 +0200, Jacob Heun notifications@github.com, wrote:

Now that npm >6 is being installed during the Travis builds, npm commands fail due to npm using let outside of strict mode on older node versions. 0.09s$ npm run lint /home/travis/.nvm/versions/node/v4.9.1/lib/node_modules/npm/bin/npm-cli.js:79 let notifier = require('update-notifier')({pkg}) ^^^ SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode at exports.runInThisContext (vm.js:53:16) at Module._compile (module.js:373:25) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Function.Module.runMain (module.js:441:10) at startup (node.js:140:18) at node.js:1043:3 Either npm needs to be locked down, or the travis node versions need to get upgraded. With node v4 having hit end of life this past April it might be best to just update travis to node 6 and 8. I've got a passing build of the upgrades to travis, it required a rebuild of the lock files to get node stable passing. https://travis-ci.org/jacobheun/pull-length-prefixed/builds/401298678 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.