fix: properly handle sync streams

dignifiedquire / pull-length-prefixed

Streaming length prefixed buffers with pull-streams

MIT License

8 stars 18 forks source link

fix: properly handle sync streams #19

Closed areth closed 5 years ago

areth commented 5 years ago

Resolves #18 Recursion in decode() blows the stack in case of sync streams. It's rewritten with a loop. The solution is inspired by pull-stream's drain. Added syncStream test. It fails with recursion, but pass with the new implementation.

areth commented 5 years ago

Build failed for stable node v11.4.0. It seems the issue is in outdated aegir. Any plans to update it?

dignifiedquire commented 5 years ago

thank you, fixed in #22