search

dignifiedquire / pull-length-prefixed

Streaming length prefixed buffers with pull-streams
MIT License
8 stars 18 forks source link

decode - handle unexpected end of stream #6

Closed kumavis closed 7 years ago

kumavis commented 7 years ago

pull streams emit 'true' or an error on drain. ( see https://github.com/pull-stream/pull-stream#source-aka-readable )

I was getting a case where the source was unexpectedly ending, and 'true' was being passed up as the error. decodeFromReader seemed like the correct place to handle this case, as it is the end of pull streams and the start of a error-first-cb api.

dignifiedquire commented 7 years ago

@kumavis why did you close this?