digraphs / Digraphs

The GAP package Digraphs
https://digraphs.github.io/Digraphs
Other
30 stars 46 forks source link

Digraphs does not load on Windows #86

Closed olexandr-konovalov closed 6 years ago

olexandr-konovalov commented 7 years ago

The following happens, despite the digraphs.so file is there:

gap> LoadPackage("dig");
───────────────────────────────────────────────────────────────────────────────────────────────────────────────
Loading  orb 4.7.6 (Methods to enumerate orbits)
by Juergen Mueller (http://www.math.rwth-aachen.de/~Juergen.Mueller),
   Max Neunhöffer (http://www-groups.mcs.st-and.ac.uk/~neunhoef), and
   Felix Noeske (http://www.math.rwth-aachen.de/~Felix.Noeske).
Homepage: https://gap-packages.github.io/orb
───────────────────────────────────────────────────────────────────────────────────────────────────────────────
───────────────────────────────────────────────────────────────────────────────────────────────────────────────
Loading  GRAPE 4.7 (GRaph Algorithms using PErmutation groups)
by Leonard H. Soicher (http://www.maths.qmul.ac.uk/~leonard/).
Homepage: http://www.maths.qmul.ac.uk/~leonard/grape/
───────────────────────────────────────────────────────────────────────────────────────────────────────────────
#W dlopen() error: No such file or directory
Error, module '/proc/cygdrive/C/gap4r8p8test/pkg/digraphs-0.10.1/bin/i686-pc-cygwin-gcc-default32/digraphs.so' not foun\
d in
  if not LOAD_DYN( arg[1], false )  then
    Error( "no support for dynamic loading" );
fi; at /proc/cygdrive/C/gap4r8p8test/lib/files.gd:579 called from
<function "LoadDynamicModule">( <arguments> )
 called from read-eval loop at line 25 of /proc/cygdrive/C/gap4r8p8test/pkg/digraphs-0.10.1/init.g
Error, was not in any namespace called from
LEAVE_NAMESPACE(  ); at /proc/cygdrive/C/gap4r8p8test/lib/package.gi:1212 called from
ReadPackage( pkgname, "init.g" ); at /proc/cygdrive/C/gap4r8p8test/lib/package.gi:1585 called from
<function "LoadPackage">( <arguments> )
 called from read-eval loop at line 1 of *stdin*
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
brk> 
james-d-mitchell commented 7 years ago

Hmmm, I don't know how to debug this, since I don't have access to a Windows computer.

Just to double check the file reported as not found is actually there?

olexandr-konovalov commented 7 years ago

yes, the binary is there, built under Cygwin. I suspect there maybe something about the initial part of the path (/proc/cygdrive/C vs /cygdrive/C). I can help to debug this from next week, mainly saving this so it's not forgotten. @jdebeule also sees this.

ChrisJefferson commented 7 years ago

proc/cygdrive is the “modern” way of access files in cygwin.

Chris

On 4 Sep 2017, at 17:24, Alexander Konovalov notifications@github.com wrote:

yes, the binary is there, built under Cygwin. I suspect there maybe something about the initial part of the path (/proc/cygdrive/C vs /cygdrive/C). I can help to debug this from next week, mainly saving this so it's not forgotten. @jdebeule also sees this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/gap-packages/Digraphs","title":"gap-packages/Digraphs","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/gap-packages/Digraphs"}},"updates":{"snippets":[{"icon":"PERSON","message":"@alex-konovalov in #86: yes, the binary is there, built under Cygwin. I suspect there maybe something about the initial part of the path (/proc/cygdrive/C vs /cygdrive/C). I can help to debug this from next week, mainly saving this so it's not forgotten. @jdebeule also sees this."}],"action":{"name":"View Issue","url":"https://github.com/gap-packages/Digraphs/issues/86#issuecomment-326987381"}}}

ChrisJefferson commented 7 years ago

How did you build this?

I tried just building master digraphs with master gap, and everything was fine.

olexandr-konovalov commented 7 years ago

This is GAP 4.8.8 installation, with official digraphs release included there. Build with ../bin/BuildPackages.sh under Cygwin, and then installed on a Cygwin-free machine.

james-d-mitchell commented 6 years ago

@alex-konovalov @jdebeule @ChrisJefferson is this still an issue? Can anyone provide some more information that might help us resolve the issue if it persists?

jdebeule commented 6 years ago

Dear James, dear Chris and Alexander,

I am unable to reproduce this problem on my installation of windows 10. In other words, digraphs loads fine.

Cheers,

Jan


Jan De Beule jan@debeule.eu Postdoctoraal onderzoeker Vrije Universiteit Brussel Vakgroep Wiskunde Pleinlaan 2 B 1050 Brussel (Belgium) http://homepages.vub.ac.be/~jdbeule/

Op 24 okt. 2017, om 10:14 heeft James Mitchell notifications@github.com het volgende geschreven:

@alex-konovalov @jdebeule @ChrisJefferson is this still an issue? Can anyone provide some more information that might help us resolve the issue if it persists?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

olexandr-konovalov commented 6 years ago

@jdebeule do you install GAP and packages in Windows 10 Linux bash shell? If so, I would not be surprised if it works. But the issue is when it is started on Windows with one of the bat-file in the bin directory.

olexandr-konovalov commented 6 years ago

P.S. I have just checked that the same happens with digraphs-0.10.1 and GAP as in the master branch.

jdebeule commented 6 years ago

Hi Alexander,

I just downloaded the pre-compiled version of GAP and all packages.

Best regards,

Jan

olexandr-konovalov commented 6 years ago

The reason was in missing cygstdc++-6.dll, as suggested by @ChrisJefferson. I have now added this to the -win.zip archive, and both Digraphs and JSON now can be loaded on Windows. So for these two packages the problem will disappear in the next GAP distribution.

olexandr-konovalov commented 6 years ago

For the record, I am going to warp and publish GAP 4.8.10 with missing dll, that will provide working Digraphs for Windows. @james-d-mitchell if you can review https://github.com/gap-system/gap/pull/2089 to ensure that your packages are handled and described correctly, that would be helpful. Thanks!

james-d-mitchell commented 6 years ago

Thanks @alex-konovalov, everything looks great.