search

digst / OIOSAML.Java

Other
11 stars 11 forks source link

Feature/nlrfim 109 #56

Closed TauBeblein closed 2 years ago

TauBeblein commented 2 years ago

Please take a look at the current implementation and comment, so changes can be fixed

TauBeblein commented 2 years ago

I have added a few TODO and unit test is also missing

mdbech commented 2 years ago

The documentation must also contain the list of new configuration parameters in the relation to logging.

TauBeblein commented 2 years ago

@jpramming I agree, if it is okay to add new dependencies. I'll start by adding a simple method to our own StringUtil class and simplify the 45 places we do isBlank tests.

TauBeblein commented 2 years ago

I have implemented changes from the pull-request comments, take a look at the code now.

TauBeblein commented 2 years ago

Everything in this pull-request is ready for review