diia-open-source / be-pkg-utils

European Union Public License 1.2
14 stars 10 forks source link

Hardcoded business-login in utilities looks strange #16

Open tshemsedinov opened 4 months ago

tshemsedinov commented 4 months ago

Keys ua and eng are hardcoded, and they have even different length (why not en if you use firstNameEN ?) thus may be an issue preventing easy porting to different languages or even add support them https://github.com/diia-open-source/be-pkg-utils/blob/e969374fb769e59ab6bbdb709caeba0199e14a8c/src/pdfUtils.ts#L87