search

diia-open-source / be-pkg-utils

European Union Public License 1.2
14 stars 10 forks source link

IBAN validation can be applied to other countries #30

Closed Amice13 closed 13 hours ago

Amice13 commented 4 months ago

I have expanded the IBAN validation algorithm to encompass numbers from all countries, rather than solely focusing on Ukraine.

FowiFlowi commented 13 hours ago

@Amice13, thank you for PR! I appreciate your action to extend functionality, but at least one issue is presented here: the duplication of CR code. And it is pretty time-consuming to check other codes and lengths. In fact, we don't need this extension right now, the time will come, and then we are going to add it with all the meticulousness that it requires