search

diia-open-source / be-pkg-validators

European Union Public License 1.2
4 stars 2 forks source link

Utilize `ObjectId.isValid` method #1

Open DemianParkhomenko opened 4 months ago

DemianParkhomenko commented 4 months ago

https://github.com/diia-open-source/be-pkg-validators/blob/5d8db1dfb7917347c1aeae6807d0499e3e1ff819/src/rules/objectId.ts#L7

static isValid(id: number | string | ObjectId | Buffer | ObjectIdLike): boolean {

https://github.com/mongodb/js-bson/blob/d685aa5a19db2ef67824b99847a380af4fa6bfe0/src/objectid.ts#L301

The current validator does not cover all cases to validate ObjectId. MongoDB provides method to validate ids

vird commented 4 months ago

What cases is not covered for hexadecimal? https://github.com/cabinjs/bson-objectid/blob/66f6f803a14b072f6c8d0d5b713cd02154f00ed0/objectid.js#L136