search

diimdeep / awesome-split-keyboards

A collection of ergonomic split keyboards ⌨
4.76k stars 198 forks source link

Preparation for submission to the master Awesome List #12

Closed NewAlexandria closed 4 years ago

NewAlexandria commented 5 years ago

Hi, I was cleaning up my awesome list, and found a few others that are interesting to me — and decided to be a friendly stranger and help prep.

did not do (but can if you merge this, and need more help)

laughedelic commented 5 years ago

Why do you change github to GitHub in URLs? Is this required by the awesome-lint?

NewAlexandria commented 5 years ago

Oddly, yes. I suspect it is a bug with some other aspect of the linting - as I think that my list didn’t require me to change this for URLs.

Probably that can be reverted and other lints done first. Then it’ll probably go away

NewAlexandria commented 5 years ago

OK, I made a round of changes during stuff today. github.com did not start linting agnostically, and I filed this issue about it: https://github.com/sindresorhus/awesome-lint/issues/71

It looks like an easy lift.

If Sindre and others give it a green light, I'd propose this PR incorporates the downcases that are coming. Or you can merge as-is and I or someone can PR the case change later.

NewAlexandria commented 5 years ago

That will probably get merged, when figured out. I found that it is only the case for non-link URLs, which are not in code-quotes.

  1. So if you like the format https://github.com/diimdeep/awesome-split-keyboards/pull/12 for a URL, then it will lint fine.
  2. We can turn the URLs into links around non-URL words. IMO this is kind of ideal, for SEO / the semantic-ness of the web, but it's the most effort and I'm not the person to do it all.
  3. Or I'll just revert the capitalization, no ticks, and then the awesome-list PR will merge without dispute later.

If (2), then I can at least help the tribe here with the table, by regexy goodness to remove the URL column, and add the URL as a link to each name column item.

Let me know @laughedelic , et. al.

NewAlexandria commented 5 years ago

ping/bump, in hopes to close out

laughedelic commented 5 years ago

(I'm not a maintainer, I was just passing by...)

NewAlexandria commented 5 years ago

@diimdeep ?

pvinis commented 4 years ago

I merged this and the other PRs before this to the new fork.

NewAlexandria commented 4 years ago

🙏