Crashes Atom

[flying-sheep]

When hitting the key combination, atom quickly becomes unresponsive.

Nothing else visibly happens.

[nshtg]

Could you open the developer console for me and look if that printed out some kind of error while atom becomes unstable?

Window: Toggle Dev Tools in the command palette

[flying-sheep]

now it loaded once (when toggled after enabiling it and opening dev tools), but went behind the tab bar.

after a restart and toggling it, then looking at the console, i got

grunt-runner: MODULE_NOT_FOUND

and

Failed to activate package named 'atomatigit' Error: 'undefined' does not exist!
  at new PromisedGit (/home/philipp/.atom/packages/atomatigit/node_modules/promised-git/lib/promised-git.js:22:15)
  at Object.<anonymous> (/home/philipp/.atom/packages/atomatigit/lib/git.coffee:11:22)
  at Object.<anonymous> (/home/philipp/.atom/packages/atomatigit/lib/git.coffee:1:1)
  at Module._compile (module.js:468:26)
  at Object.requireCoffeeScript [as .coffee] (/opt/atom/resources/app/src/coffee-cache.js:61:19)
  at Module.load (/opt/atom/resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:318:12)
  at Module.require (module.js:373:17)
  at require (module.js:392:17)
  at Object.<anonymous> (/home/philipp/.atom/packages/atomatigit/lib/models/repo.coffee:8:31)
  at Object.<anonymous> (/home/philipp/.atom/packages/atomatigit/lib/models/repo.coffee:1:1)
  at Module._compile (module.js:468:26)
  at Object.requireCoffeeScript [as .coffee] (/opt/atom/resources/app/src/coffee-cache.js:61:19)
  at Module.load (/opt/atom/resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:318:12)
  at Module.require (module.js:373:17)
  at require (module.js:392:17)
  at Object.<anonymous> (/home/philipp/.atom/packages/atomatigit/lib/atomatigit.coffee:1:13)
  at Object.<anonymous> (/home/philipp/.atom/packages/atomatigit/lib/atomatigit.coffee:1:1)
  at Module._compile (module.js:468:26)
  at Object.requireCoffeeScript [as .coffee] (/opt/atom/resources/app/src/coffee-cache.js:61:19)
  at Module.load (/opt/atom/resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:318:12)
  at Module.require (module.js:373:17)
  at require (module.js:392:17)
  at Package.module.exports.Package.requireMainModule (/opt/atom/resources/app/src/package.js:597:34)
  at Package.module.exports.Package.activateConfig (/opt/atom/resources/app/src/package.js:242:12)
  at Package.module.exports.Package.activateNow (/opt/atom/resources/app/src/package.js:224:14)
  at /opt/atom/resources/app/src/package.js:656:29
  at Emitter.module.exports.Emitter.emit (/opt/atom/resources/app/node_modules/event-kit/lib/emitter.js:71:11)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/opt/atom/resources/app/src/command-registry.js:224:20)
  at /opt/atom/resources/app/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/opt/atom/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:549:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/opt/atom/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:391:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/opt/atom/resources/app/src/window-event-handler.js:157:20)

and after uninstalling/reinstalling, i get the following, then the stacktrace above:

Error activating package config for “atomatigit” Error: 'undefined' does not exist!
/opt/atom/resources/app/node_modules/settings-view/lib/settings-view.js:419

iterator
/opt/atom/resources/app/node_modules/settings-view/lib/settings-view.js:419

(anonymous function)
/opt/atom/resources/app/node_modules/fs-plus/node_modules/async/lib/async.js:111

_each
/opt/atom/resources/app/node_modules/fs-plus/node_modules/async/lib/async.js:32

async.each
/opt/atom/resources/app/node_modules/fs-plus/node_modules/async/lib/async.js:110

module.exports.SettingsView.activatePackages
/opt/atom/resources/app/node_modules/settings-view/lib/settings-view.js:424

(anonymous function)
/opt/atom/resources/app/node_modules/settings-view/lib/settings-view.js:97

hang still not reproducable.

[oliverpool]

Hi, the error Failed to activate package named 'atomatigit' Error: 'undefined' does not exist! might be caused because at the opening of atom, no git folder is opened

Hence, in the file https://github.com/diiq/atomatigit/blob/master/lib/git.coffee#L11 getPath() is undefined.

At the startup, maybe it needs to check if a git repo is opened or not

[oliverpool]

The PR #27 probably fixes this issue (https://github.com/diiq/atomatigit/pull/27/files#diff-2dbd21106c7981b7906a5613ee128947L108)

[flying-sheep]

well, it was a git repo, so unless misnamed, that commit shouldn’t fix it.

but then again, it works now anyway oO