search

diivm / pcl

Point Cloud Library (PCL)
http://www.pointclouds.org
Other
0 stars 0 forks source link

add type info and change to != #7

Closed diivm closed 4 years ago

kunaltyagi commented 4 years ago
diivm commented 4 years ago

what [o/p] stands for

Output files commits (generated JSONs)

Any reason for putting the json in git?

Just for the time being, including outputs for review (if needed). Will remove them later.

What's type_kind?

The type of element. Need it for member type: https://github.com/divmadan/pcl/blob/62bb91df43db36a77e0dddab17eaa57eee6ead1b/bindings/python/json/common/impl/point_types.json#L214-L215

What's the difference in is not and !=?

is not wasn't filtering for "Invalid"

diivm commented 4 years ago

It's showing conflicts but the conflict is my change. Might be something to do with this. Wasn't able to make pull requests earlier today.

kunaltyagi commented 4 years ago

What's type_kind?

The type of element. Need it for member type:

In that case, wouldn't it be better to rename the variable as type_of_element?