search

dijs / wiki

Wikipedia Interface for Node.js
MIT License
315 stars 61 forks source link

Bundle size got very big for v6 #125

Closed eyaleizenberg closed 4 years ago

eyaleizenberg commented 4 years ago

The bundle size grew from 9.6KB gzipped (V5) to 101.9KB (V6):

Screen Shot 2019-08-21 at 17 22 44
dijs commented 4 years ago

Yeah... that is because I added cheerio as a dependency for parsing HTML blobs. I could have parsed with RegEx, but with all the different flavors of markup Wiki's like to use, that did not seem smart. So I opted for a well-maintained library that already does this.

If this size difference really hurts performance for you, please continue to use the v5 of WikiJS

I will try to keep both v5 and v6 moving for a while.

Let me know if you have any other thoughts on the matter.

dijs commented 3 years ago

I found a way to parse without using cheerio, now the size is much smaller.

https://bundlephobia.com/result?p=wikijs@6.1.3