search

dijs / wiki

Wikipedia Interface for Node.js
MIT License
315 stars 61 forks source link

bluebird promises #6

Closed ghost closed 9 years ago

ghost commented 9 years ago

When using bluebird Promise.promisifyAll on wiki it doesn't apply on WikiPage class objects. Like there appears method searchAsync, pageAsync but no methods of page like summaryAsync(it works if call promisification on each new object). Would be great to have WikiPage class definition exported from module(to extend once). Thanks for project.

dijs commented 9 years ago

Sorry this is so late, but I just did a huge update on this project. I am not sure if you are still interested, but I have converted all the methods to return promises now. Might want to check out the documentation, many things have changed. Let me know if you run into any problems.

ghost commented 9 years ago

Thanks a lot for your work! Will look by the next Monday. I think you should add to .gitignore npm-debug.log