Closed kper closed 6 years ago
The function findById did not return the same object like page. The API options must be the same for consistency.
findById
page
Before:
{ raw: { pageid: 68187, ns: 0, title: 'FC Barcelona' }, html: [Function: html], content: [Function: content], summary: [Function: summary], images: [Function: images], references: [Function: references], links: [Function: links], categories: [Function: categories], coordinates: [Function: coordinates], info: [Function: q], backlinks: [Function: backlinks], rawImages: [Function: h], mainImage: [Function: mainImage], langlinks: [Function: langlinks], rawInfo: [Function: p] }
After:
{ raw: { pageid: 68187, ns: 0, title: 'FC Barcelona', contentmodel: 'wikitext', pagelanguage: 'en', pagelanguagehtmlcode: 'en', pagelanguagedir: 'ltr', touched: '2017-10-10T06:06:26Z', lastrevid: 803940480, length: 150109, fullurl: 'https://en.wikipedia.org/wiki/FC_Barcelona', editurl: 'https://en.wikipedia.org/w/index.php?title=FC_Barcelona&action=edit', canonicalurl: 'https://en.wikipedia.org/wiki/FC_Barcelona' }, html: [Function: html], content: [Function: content], summary: [Function: summary], images: [Function: images], references: [Function: references], links: [Function: links], categories: [Function: categories], coordinates: [Function: coordinates], info: [Function: q], backlinks: [Function: backlinks], rawImages: [Function: h], mainImage: [Function: mainImage], langlinks: [Function: langlinks], rawInfo: [Function: p] }
Good call. Can you fix the tests for this?
Test should handle Issue #55 failed
should handle Issue #55
Can you rerun the CI job?
Running again.
Coverage remained the same at 99.153% when pulling d5ea1f3a831579ff1e7379cd828c0039c1bb27e0 on kper:master into 7003a9a602e83207df0b1297d4c4aa1774b68a8c on dijs:master.
Published in v4.3.1
The function
findById
did not return the same object likepage
. The API options must be the same for consistency.Before:
After: