search

dijs / wiki

Wikipedia Interface for Node.js
MIT License
313 stars 62 forks source link

Typescript - Type definition #66

Closed mbale closed 6 years ago

mbale commented 6 years ago

I've done the type definition. Should I make a PR to be bundled or do you want it to be part of @types? (https://github.com/DefinitelyTyped/DefinitelyTyped)

dijs commented 6 years ago

I am not familiar with this. Can you explain?

mbale commented 6 years ago

You can read here more. (http://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html)

I have a typescript project and it was needed to implement type declarations. It can be handy if someone's coding in typescript or using visual code (because under the hood it's using intellisense).

dijs commented 6 years ago

If it is normal to keep these in the project code, I would be more than happy to merge your types file.

Thanks for the work!

mbale commented 6 years ago

Thank you! I'm going to make PR tomorrow.

dijs commented 6 years ago

Published in v4.4.0