Issue #121, Issue #140 - Githubissues

Josephblt commented 6 years ago

Min Max Constraints Support - Issue #121 Round Corners Support - Issue #140. This fixes only part of the problem.

romartin commented 6 years ago

Hey @Josephblt Thanks for this, anyway still missing 2 things:

Please change the commit message to reference the right ticket number (I think 121 is not the right one..). So just updating the commit message and force pushing again is fine.
While dragging the resize CP, the shape size is being "constrained", that's working fine, but the concrete CP that is being drag, is still being located as the drag mouse location... I would expect forcing the location for the concrete CP as well, once it gets to its min/max, WDYT?

See issue: resize-constraints-issue

We're actually doing the same for shape docking - once a shape is being docked, while dragging it, it's located at the dock location although you keep moving the mouse ...

Josephblt commented 6 years ago

Yeah sure. Will work on those changes now.

2017-10-23 15:12 GMT-02:00 Roger Martínez notifications@github.com:

@romartin requested changes on this pull request.

Requested changes. See message above.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ahome-it/lienzo-core/pull/198#pullrequestreview-71260684, or mute the thread https://github.com/notifications/unsubscribe-auth/AYMakgUQBq75y1GV5uuCHk1SB6M6nDvwks5svMj4gaJpZM4QAuoQ .

romartin commented 6 years ago

@Josephblt I think the best option is just setting a drag constraint enforcer for each of the resize CPs, and apply the right adjust once getting to the min/max values, if makes sense.

dikalo / lienzo-core

Issue #121, Issue #140 #198