search

dikalo / lienzo-core

Lienzo Structure Graphics GWT Toolkit
Apache License 2.0
51 stars 58 forks source link

Adding support to Control Point Handler to be extended via Factory, c… #206

Closed tiagodolphine closed 6 years ago

tiagodolphine commented 6 years ago

Add support to Wires Connector Control Points Handlers to be extended and injected on WiresManager through the WiresHandlerFactory, this will be used by Stunner to integrate with the Model and Commands. Some methods were added to WiresConnectorControlImpl to create and remove control points from connectors. Code refactory improvements based on factory to WiresShapeHandler, in the same way as for connectors on WiresHandlerFactory.

Related JIRA https://issues.jboss.org/browse/JBPM-5962.

Some tests were added to the https://github.com/ahome-it/lienzo-tests as well.

@romartin can you please help to review and add any other that may be important on the reviewing .

Thanks!

tiagodolphine commented 6 years ago

@romartin I just renamed the WiresConnectorControlHandler to WiresControlPointHandler.

SprocketNYC commented 6 years ago

Let me know if this is good to go Roger

romartin commented 6 years ago

Oh @SprocketNYC sorry did not realized about your comment. No worries thanks a lot!! for now it's fine, no actions needed, we'll not merge yet this... thanks!!