dikhan / terraform-provider-openapi

OpenAPI Terraform Provider that configures itself at runtime with the resources exposed by the service provider (defined in a swagger file)

Apache License 2.0

275 stars 48 forks source link

Feature/be able to use dash #187

Closed smutel closed 4 years ago

smutel commented 4 years ago

Proposed changes

Currently dashes in resource name are not accepted.

Type of change

[ ] Bug-fix (change that fixes current functionality)
[x] New feature (change that adds new functionality)

=> Resolve #188

Checklist

Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

[X] I have read and followed the CONTRIBUTING guidelines
[X] I have made sure code compiles correctly
[X] I have run 'make test' locally from the terraform_provider_api folder and no errors were found
[X] I have added tests that prove my fix is effective or that my feature works
[ ] I have added/updated necessary documentation (if appropriate)

codecov[bot] commented 4 years ago

Codecov Report

Merging #187 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #187      +/-   ##
=========================================
+ Coverage   89.69%   89.7%   +<.01%     
=========================================
  Files          51      51              
  Lines        3048    3049       +1     
=========================================
+ Hits         2734    2735       +1     
  Misses        206     206              
  Partials      108     108

Impacted Files	Coverage Δ
openapi/openapi_v2_resource.go	`93.84% <100%> (+0.01%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 391a8c9...ca11f14. Read the comment docs.

dikhan commented 4 years ago

Hi @smutel ,

Thanks for creating the PR! Would you mind opening an issue that describes the problem this PR solves? I see the PR contains a brief summary, so perhaps you can reuse that and also provide some more info in terms on what the acceptance criteria is etc.

To provide more context on why having the issue described is important, it helps keeping track of the problems we are trying to solve, prioritise them accordingly, have some history that we can refer back to and also the new versions of the plugin released have links to the issues fixed too.

I will try to take a look at the PR sometime this week.

dikhan commented 4 years ago

Thanks for contributing @smutel !