[BugFix: Issue #300]: ServiceConfiguration with InsecureSkipVerify enabled now works as expected

[dikhan]

What problem does this Pull Request solve?

Please link to the issue number here (issue will be closed when PR is merged): Closes #300

Summary of changes:

• Moved the logic that handled the TLSClient InsecureSkipVerify enablement from getServiceConfiguration to the CreateSchemaProviderFromServiceConfiguration.
• Added more logging when the InsecureSkipVerify is enabled with appropriate warnings
• Added more test coverage on CreateSchemaProviderFromServiceConfiguration method
• Moved the skipVerify env variable check if the otfVarSwaggerURL is also set as it was only used there but yet initialized outside for no particular reason.

Type of change

What type of change does your code introduce to the provider? Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

• [ ] New feature (change that adds new functionality)
• [x] Bug-fix (change that fixes current functionality)
• [ ] Tech debt (enhances the current functionality)
• [ ] New release (pumps the version)

Checklist

Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

• [x] I have read and followed the CONTRIBUTING guidelines
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] I have made sure code compiles correctly and all tests are passing by running make test-all
• [x] I have added/updated necessary documentation (if appropriate)
• [x] I have added the following info to the title of the PR (pick the appropriate option for the type of change). This is important because the release notes will include this information.
  • [ ] Feature Request: PRs related to feature requests should have in the title [FeatureRequest: Issue #X] <PR Title>
  • [x] Bug Fixes: PRs related to bug fixes should have in the title [BugFix: Issue #X] <PR Title>
  • [ ] Tech Debt: PRs related to technical debt should have in the title [TechDebt: Issue #X] <PR Title>
  • [ ] New Release: PRs related to a new release should have in the title [NewRelease] vX.Y.Z

Checklist for Admins

• [x] Label is populated
• [x] PR is assigned to the corresponding project
• [ ] PR has at least 1 reviewer and 1 assignee

[codecov[bot]]

Codecov Report

Merging #301 (c7a72ea) into master (d5699cb) will increase coverage by 0.39%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   92.14%   92.54%   +0.39%     
==========================================
  Files          60       60              
  Lines        3069     3071       +2     
==========================================
+ Hits         2828     2842      +14     
+ Misses        163      155       -8     
+ Partials       78       74       -4     

Impacted Files	Coverage Δ
openapi/plugin_config.go	71.01% <100.00%> (+0.42%)	:arrow_up:
openapi/provider.go	88.23% <100.00%> (+33.68%)	:arrow_up:
openapi/plugin_config_services_stub.go	84.61% <0.00%> (+7.69%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5699cb...c7a72ea. Read the comment docs.