Closed Sreeratm closed 2 years ago
Unit Test Passing Outputs for $make test-all
Looks like the build notification was not sent properly to travis ci and the build has not started. Gonna attempt to force push a build by closing the PR and reopening it again and hopefully that will unblock the PR build.
Additionally, I will open a ticket with travis ci to get more info about why this happened.
Looks like the closing and immediate reopening of the PR did the trick, waiting for the build to finish, generally the changes look good.
Merging #332 (c199384) into master (0b9b746) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 93.66% 93.66%
=======================================
Files 60 60
Lines 3584 3584
=======================================
Hits 3357 3357
Misses 160 160
Partials 67 67
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0b9b746...c199384. Read the comment docs.
Thanks @dikhan
What problem does this Pull Request solve?
Type of change
What type of change does your code introduce to the provider? Please put an
x
(w/o heading/trailing white spaces) in the boxes that apply:Checklist
Please put an
x
(w/o heading/trailing white spaces) in the boxes that apply:make test-all
[FeatureRequest: Issue #X] <PR Title>
[BugFix: Issue #X] <PR Title>
[TechDebt: Issue #X] <PR Title>
[NewRelease] vX.Y.Z
Checklist for Admins