search

diku-dk / bfast

GPU Implementation for BFAST
GNU General Public License v3.0
37 stars 16 forks source link

pyhton backend n_chunk is never used #30

Closed 12rambau closed 3 years ago

12rambau commented 3 years ago

I checked the file https://github.com/diku-dk/bfast/blob/master/bfast/monitor/python/base.py and the n_chunks parameter of the fit function is never used. Do you prefer to implement a chunk loop or discard the parameter ?

mortvest commented 3 years ago

It should definitely not have a chunk loop. This can be fixed it in the boilerplate, so that we keep the same API for all backends, but the parameter would be ignored.

mortvest commented 3 years ago

Fixed

12rambau commented 3 years ago

Can you point me to the commit that implemented the change ? It useful to follow up with your devs and to pull this kind of improvement in my branches.

If you have not yet pushed the modification to github, would you mind letting the issue open, for me closing means both "fixed" and "available to developers".