search

diku-dk / bfast

GPU Implementation for BFAST
GNU General Public License v3.0
37 stars 16 forks source link

Stable period determination not implemented #44

Open fnands opened 2 years ago

fnands commented 2 years ago

Hi,

I had a look at the python version and if I'm not mistaken a stable history period is never determined as in section 2.4 of the paper.

Am I correct, or did I misunderstand the code? I tried to read the futhark implementation and it doesn't seem to be there either.

fnands commented 2 years ago

Oh, I see there is a PR by @nhey that implements it. Can it be merged?

mortvest commented 2 years ago

I don't have the time to test the ROC implementation right now. Have you tried using the branch? I am planning a big overhaul of the whole package in the near future, and it will be included there