In Windows, the which package appends ".EXE" to the path. Because file validation was performed using .endsWith(langName), this caused the extension to fail on Windows machines. Additionally, since the focus was on file paths, a user would not be able to configure futhark-vscode to use WSL. I refactored the extension to remove the filename validation, which also allowed me to add WSL support. My assumption is that the Futhark version check is sufficient enough validation.
I also modified some of the messages and added options to the error windows, but you're free to remove these changes. My main goal is the fix for Windows and WSL support.
Changes
Changed Futhark version check to use regex capture groups.
Removed filename validation.
Removed dependency for which.
Added WSL options to version check and language client.
Added "Use WSL" extension setting.
Renamed findFutharkExecutable to validateFutharkPath.
validateFutharkPath changed to return a ServerOptions object.
Added options to error message windows.
Changed wording of error messages and futharkExecutablePath description.
athas
commented
1 year ago
Summary
In Windows, the
whichpackage appends ".EXE" to the path. Because file validation was performed using.endsWith(langName), this caused the extension to fail on Windows machines. Additionally, since the focus was on file paths, a user would not be able to configurefuthark-vscodeto use WSL. I refactored the extension to remove the filename validation, which also allowed me to add WSL support. My assumption is that the Futhark version check is sufficient enough validation.I also modified some of the messages and added options to the error windows, but you're free to remove these changes. My main goal is the fix for Windows and WSL support.
Changes
Changed Futhark version check to use regex capture groups.
Removed filename validation.
Removed dependency for
which.Added WSL options to version check and language client.
Added "Use WSL" extension setting.
Renamed
findFutharkExecutabletovalidateFutharkPath.validateFutharkPathchanged to return aServerOptionsobject.Added options to error message windows.
Changed wording of error messages and
futharkExecutablePathdescription.