LIBYUV_DISABLE_CPU - Githubissues

dilagurung / libyuv

Automatically exported from code.google.com/p/libyuv

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

LIBYUV_DISABLE_CPU #189

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

When the assembly language doesn't build, there is a macro, LIBYUV_DISABLE_ASM 
that builds without assembly.  But often only one CPU is broken, and it may not 
be one that affects the project.
So I propose a feature that isolates the CPU's to be disabled.  There should be 
macros that correspond to each CPU variation.
/DLIBYUV_DISABLE_SSE2
To disable just the SSE2, but not the AVX2 or NEON.

Original issue reported on code.google.com by fbarch...@google.com on 20 Feb 2013 at 3:28

GoogleCodeExporter commented 9 years ago

There are quite a few instructions sets on X86, so I revise my proposal to
replace YUV_DISABLE_ASM
with a macro per CPU.
LIBYUV_DISABLE_NEON
LIBYUV_DISABLE_MIPS
LIBYUV_DISABLE_X86

Original comment by fbarch...@chromium.org on 26 Feb 2013 at 10:06

Changed state: Started

GoogleCodeExporter commented 9 years ago

With LIBYUV_DISABLE_X86
466,122 libyuv.lib
1,159,680 libyuv_unittest.exe

Without LIBYUV_DISABLE_X86
683,298 libyuv.lib
1,206,784 libyuv_unittest.exe

Original comment by fbarch...@chromium.org on 26 Feb 2013 at 11:49

GoogleCodeExporter commented 9 years ago

Fixed in r582.

Original comment by fbarch...@chromium.org on 27 Feb 2013 at 12:20

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

r586 adds comments to the gyp files on macro usage.

Original comment by fbarch...@chromium.org on 28 Feb 2013 at 12:06