dilagurung / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

valgrind error on attenuate #195

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
tsan fail

libyuvTest.TestAttenuate: 
unit_test/planar_test.cc:62: Failure
Value of: unatten_pixels[1][0]
  Actual: '\x10' (16)
Expected: 0u
Which is: 0
unit_test/planar_test.cc:63: Failure
Value of: unatten_pixels[1][1]
  Actual: '@' (64, 0x40)
Expected: 0u
Which is: 0
unit_test/planar_test.cc:64: Failure
Value of: unatten_pixels[1][2]
  Actual: '\xC0' (192)
Expected: 0u
Which is: 0

Original issue reported on code.google.com by fbarch...@chromium.org on 5 Mar 2013 at 5:07

GoogleCodeExporter commented 9 years ago
>set LIBYUV_DISABLE_SSE2=1
>out\release\libyuv_unittest --gtest_filter=*ten*

Note: Google Test filter = *ten*
[==========] Running 9 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 9 tests from libyuvTest
[ RUN      ] libyuvTest.TestAttenuate
d:\src\libyuv\trunk\unit_test\planar_test.cc(62): error: Value of: 
unatten_pixels[1][0]
  Actual: '\x10' (16)
Expected: 0u
Which is: 0
d:\src\libyuv\trunk\unit_test\planar_test.cc(63): error: Value of: 
unatten_pixels[1][1]
  Actual: '@' (64, 0x40)
Expected: 0u
Which is: 0
d:\src\libyuv\trunk\unit_test\planar_test.cc(64): error: Value of: 
unatten_pixels[1][2]
  Actual: '\xC0' (192)
Expected: 0u
Which is: 0
[  FAILED  ] libyuvTest.TestAttenuate (479 ms)

The reason is a behavior change for alpha=0 in sse/avx2.  The rgb is set to 0.
The C code needs to match the SSE code.

Original comment by fbarch...@chromium.org on 5 Mar 2013 at 5:40

GoogleCodeExporter commented 9 years ago
Fixed in r589

Original comment by fbarch...@chromium.org on 5 Mar 2013 at 6:08