search

dilanx / craco

Create React App Configuration Override, an easy and comprehensible configuration layer for Create React App.
https://craco.js.org
Apache License 2.0
7.43k stars 499 forks source link

Add icon to vscode-material-icon-theme #474

Closed Gu-Miao closed 1 year ago

Gu-Miao commented 1 year ago

I want to add craco icon support for VSCode using vscode-material-icon-theme. So I created a PR to their repo. I think @dilanx you should know this matter.

And, I need some help with these two things:

  1. I noticed that craco had a Apache License 2.0 LICENSE which has a Trademark use limitation. It says "This license explicitly states that it does NOT grant trademark rights, even though licenses without such a statement probably do not grant any implicit trademark rights." I don't know much about this, will this limitation have any impact on PR?
  2. They gave some adivce to the icon, I think maybe we can discuss about it?
dilanx commented 1 year ago

Great idea, @Gu-Miao.

For the trademark use limitation, it should be fine since the logo is used in a context that directly relates to craco (in this case, it's the config files).

I read the advice and think it's good. I can get an official svg for the icon as they described. I'll comment here once it's ready so you can update your PR with it.

Gu-Miao commented 1 year ago

It's very nice to hear that. Looking forward to your icon.😃

dilanx commented 1 year ago

Hey @Gu-Miao. Here's the official icon you can submit in your PR: https://github.com/dilanx/craco/blob/main/website/static/img/craco-icon.svg (raw)

Make sure to use that exact file and do not make any modifications to it, but feel free to let me know if they ask for any more changes. Thanks!

Gu-Miao commented 1 year ago

Sorry for the late reply, the icon is nice and I've updated my PR. Thanks a lot for the help!