search

dilanx / craco

Create React App Configuration Override, an easy and comprehensible configuration layer for Create React App.
https://craco.js.org
Apache License 2.0
7.43k stars 499 forks source link

feat: Override CRA paths #489

Closed attilapolakovics closed 1 year ago

attilapolakovics commented 1 year ago

(Had to recreate it) We needed a way to override CRAs appHtml paths and some others in our monorepo, so I've created a way to override any of the default CRA path strings. I saw that this is already requested in several issues (https://github.com/dilanx/craco/issues/104 seems to be the main one, still open ones are https://github.com/dilanx/craco/issues/414 and maybe https://github.com/dilanx/craco/issues/481) and even a PR was made that was closed eventually.

The method of overriding the path config follows the same logic as the other features of the package, you can either pass an object containing the definitions or specify a function that returns them.

After the new path values are set, the context paths also get overridden, for the sake of consistency.

dilanx commented 1 year ago

Thanks. Sorry for the delay, I've been super busy. I'll be taking a look at open PRs hopefully by next week.

dilanx commented 1 year ago

Good feature, and implementation looks good to me. I'll release it with 7.1.0 and will plan to document it.

attilapolakovics commented 1 year ago

Thank you!