search

dilanx / craco

Create React App Configuration Override, an easy and comprehensible configuration layer for Create React App.
https://craco.js.org
Apache License 2.0
7.43k stars 499 forks source link

Fixed issue where postcss plugins weren't being applied #513

Closed stevenewald closed 1 year ago

stevenewald commented 1 year ago

Previously, loader.options.postcssOptions.plugins was assigned to () => postcssPlugins, which was incorrect. It should instead directly assign the value of the plugins array.

This PR should fix the issues mentioned in #505 and #506 - hopefully it fixes #478, but I haven't tested this.

hsbtr commented 1 year ago

looking forward to

tzachyrm commented 1 year ago

@dilanx Hi :) First of all, thank you for making Craco work with CRA 5!! Any chance for a quick version release that includes this fix?

real-jacket commented 1 year ago

@stevenewald @dilanx Me too !

real-jacket commented 1 year ago

@dilanx Hi :) First of all, thank you for making Craco work with CRA 5!! Any chance for a quick version release that includes this fix?

I resolved this by the patch-package. You can have a try.