search

dilaragorum / movie-go

https://medium.com/@dilaragorum/lets-build-a-movie-api-with-clean-architecture-ef1f555b563d
53 stars 7 forks source link

Improvements #1

Open kataras opened 2 years ago

kataras commented 2 years ago

Hello @dilaragorum, good tutorial especially for newcomers to Go language.

I have some recommendations to propose:

  1. Add a README.md file which should describe your work (clopy of your tutorial)
  2. Add .gitignore file which will exclude binaries and editor/ide settings
  3. Add .github folder which should contain "Github actions" for your tests
  4. Try to simplify the test files by using a test framework in order to reduce code ducplications such as json marshal and unmarshal of your movie objects
  5. Drop httprouter dependency from your tests, your end-to-end HTTP tests should be able to run no matter the backend framework
  6. Think of using Iris (Notice: I am the repository owner) which will help you organise your services and tests further

Thanks, Great job again, keep going!

dilaragorum commented 2 years ago

What great valuable feedback is! I am very glad to hear your comments. It's really important for me. By taking them into consideration, ı will do all of these as soon as possible.

Thank you for your support!

kataras commented 2 years ago

It's my pleasure @dilaragorum, keep up!