dilevin / Bartels

49 stars 15 forks source link

Naming inconsistency in shape function derivatives #3

Closed abhimadan closed 4 years ago

abhimadan commented 4 years ago

In the *_dphi_dX functions, the output variable is named dX, but this same value is named dXinv in the *_dq2 and *_dq functions. I think this is true for both the main source files and the mex wrappers.

dilevin commented 4 years ago

I've renamed all these variables as dphidX because they are the gradients of the shape functions (phi) with respect to the reference element configuration (X).