search

dilevin / DGPCompFab

This repository stores the the assignments and lecture notes for the University of Toronto Graduate Course Computational Design and Fabrication
7 stars 4 forks source link

libfive isnan error still throws when building A1? #3

Closed wwwaldo closed 6 years ago

wwwaldo commented 6 years ago

Hello!

I pulled from the repo to commit 1b5a4d9e8143cfb1a1e51f145e76aaae6f6b59b9 after installing cling.

When I ran make on A1, I still got the isnan error on libfive. I had to change isnan -> std::isnan in two files.

A1 built after making this change.

wwwaldo commented 6 years ago

Oh, this was happening because git pull doesn't update submodules by default.

See https://stackoverflow.com/questions/1030169/easy-way-to-pull-latest-of-all-git-submodules .